fix(types): env variables override ContextVariableMap #2987

KaelWD · 2024-06-18T06:00:06Z

declare module 'hono' {
  interface ContextVariableMap {
    test: 'root'
  }
}

const middleware = createMiddleware<{
  Variables: {
    test: 'override'
  }
}>(async (c, next) => {
  c.set('test', 'override')
  await next()
})

const router = new Hono()
  .get(
    '/test',
    middleware,
    async c => {
      const test = c.get('test')
      //    ^? "root"
      return c.text(test) // 'override', type doesn't match
    },
  )

const app = new Hono()
  .use(async (c, next) => {
    c.set('test', 'root')
    await next()
  })
  .route('/', router)

codecov · 2024-06-18T06:03:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.75%. Comparing base (e6bfb45) to head (b05942e).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2987      +/-   ##
==========================================
+ Coverage   94.73%   94.75%   +0.01%     
==========================================
  Files         136      136              
  Lines       13339    13339              
  Branches     2245     2265      +20     
==========================================
+ Hits        12637    12639       +2     
+ Misses        702      700       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yusukebe · 2024-06-19T06:16:47Z

Hi @KaelWD !

We have to fix it. I've added a test by myself. It looks good, so I'm merging now. Thanks!

env variables should override ContextVariableMap

d411b9a

KaelWD changed the title ~~env variables should override ContextVariableMap~~ fix(types): env variables override ContextVariableMap Jun 18, 2024

KaelWD mentioned this pull request Jun 18, 2024

app.route includes middleware from previous groups #2988

Open

add a test

b05942e

yusukebe merged commit b074f07 into honojs:main Jun 19, 2024
14 checks passed

KaelWD deleted the patch-1 branch June 19, 2024 07:02

WomB0ComB0 mentioned this pull request Jul 11, 2024

[Snyk] Upgrade hono from 4.3.3 to 4.4.7 WomB0ComB0/gdsc-farmingdale-links-api#15

Merged

dustinsmith1024 mentioned this pull request Jul 11, 2024

4.4.7 broke array types in Context #3131

Closed

maehue mentioned this pull request Jul 25, 2024

[Snyk] Upgrade hono from 4.3.4 to 4.4.11 maehue/bun-hono-react-chat-app#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(types): env variables override ContextVariableMap #2987

fix(types): env variables override ContextVariableMap #2987

KaelWD commented Jun 18, 2024 •

edited

Loading

codecov bot commented Jun 18, 2024 •

edited

Loading

yusukebe commented Jun 19, 2024

fix(types): env variables override ContextVariableMap #2987

fix(types): env variables override ContextVariableMap #2987

Conversation

KaelWD commented Jun 18, 2024 • edited Loading

codecov bot commented Jun 18, 2024 • edited Loading

Codecov Report

yusukebe commented Jun 19, 2024

KaelWD commented Jun 18, 2024 •

edited

Loading

codecov bot commented Jun 18, 2024 •

edited

Loading